Skip to content

Conversation

Faless
Copy link
Contributor

@Faless Faless commented Oct 15, 2023

And clean it up a bit.

Follow up on #1247

@Faless Faless added enhancement This is an enhancement on the current functionality platform:web topic:buildsystem Related to the buildsystem or CI setup labels Oct 15, 2023
@Faless Faless added this to the 4.2 milestone Oct 15, 2023
@Faless Faless requested a review from a team as a code owner October 15, 2023 11:09
@Faless Faless requested a review from a team as a code owner October 15, 2023 11:13
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Changes look good to me. I also tested with the Summator demo (using Emscripten 3.1.18) and everything worked as expected.

@dsnopek dsnopek merged commit 4320c62 into godotengine:master Oct 15, 2023
@Faless Faless deleted the build/web_rename branch October 15, 2023 15:12
@dsnopek
Copy link
Collaborator

dsnopek commented Oct 23, 2023

Cherry-picked for 4.1 in PR #1281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality platform:web topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants